Add a few more HandshakeRequest parsing tests #13397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelm12
requested review from
BrennanConroy,
analogrelay and
halter73
as code owners
halter73
reviewed
Aug 26, 2019
| [InlineData("{\"protocol\":\"\",\"version\":10,\"unknown\":null}\u001e", "", 10)] | ||
| [InlineData("{\"protocol\":\"firstProtocol\",\"protocol\":\"secondProtocol\",\"version\":1}\u001e", "secondProtocol", 1)] | ||
| [InlineData("{\"protocol\":\"firstProtocol\",\"protocol\":\"secondProtocol\",\"version\":1,\"version\":75}\u001e", "secondProtocol", 75)] | ||
| [InlineData("{\"protocol\":\"dummy\",\"version\":1,\"ignoredField\":99}\u001e", "dummy", 1)] |
Member
There was a problem hiding this comment.
What happens if there's multiple json objects prior to the \u001e delimiter.
Member
There was a problem hiding this comment.
Add some tests for escaped property names too
Contributor
Author
There was a problem hiding this comment.
What happens if there's multiple json objects prior to the \u001e delimiter.
For the handshake, the parsing logic returns as soon as the end of the json object is found. So the paylod
"{\"protocol\":\"json\",\"version\":1}{\"protocol\":\"wrong\",\"version\":99}\u001e" would result in a Handshake request message with json and version 1.
BrennanConroy
approved these changes
Aug 27, 2019
Contributor
Author
|
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some tests to check that we properly parse some different unusual
HandshakeRequestmessages. This came out of the meeting earlier today.